feat(web): redirect authenticated users away from login page#2928
Closed
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Closed
feat(web): redirect authenticated users away from login page#2928devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
❌ Deploy Preview for hyprnote failed.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
ComputelessComputer
requested review from
yujonglee
and removed request for
ComputelessComputer
ComputelessComputer
deleted the
devin/1767945457-auth-redirect-when-logged-in
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user with an active auth session visits the
/auth(login) page withflow=web, they are now automatically redirected away from the login page. The redirect destination is either theredirectsearch param if provided, or/app/accountby default.This mirrors the inverse logic in
/_view/app/route.tsxwhich redirects unauthenticated users TO/auth.Desktop flow (
flow=desktop) is intentionally unaffected to allow the desktop app OAuth handshake to complete.Security
The redirect parameter is validated to prevent open redirect attacks. URLs starting with
http://,https://, or//are rejected and fall back to/app/account.Review & Testing Checklist for Human
/auth?flow=webwhile logged in - should redirect to/app/account/auth?flow=web&redirect=/pricingwhile logged in - should redirect to/pricing/auth?flow=web&redirect=https://evil.comwhile logged in - should redirect to/app/account(NOT evil.com)/auth?flow=web&redirect=//evil.comwhile logged in - should redirect to/app/account/auth?flow=desktopwhile logged in - should NOT redirect (allows OAuth to complete)/authwhile logged out - should show login page normallyNotes
Requested by @ComputelessComputer
Link to Devin run